Focus contamination warn on PLC potential#62
Merged
Conversation
masukomi
reviewed
Apr 13, 2026
Member
masukomi
left a comment
masukomi
left a comment
There was a problem hiding this comment.
I found some quickie bugs (duplicated languages in multiple places) and suggest the addition of a couple languages to the aux languages
| func TestAnalyze_AuxiliaryOnlyMismatches(t *testing.T) { | ||
| // python + bash + yaml: auxiliary mismatches should score low | ||
| // python + bash + yaml: auxiliary categories are not mismatches | ||
| languages := []string{"python", "python", "bash", "yaml"} |
Member
There was a problem hiding this comment.
thoughts re this:
"python"is listed twice- According to our skill corpus
shandshellappear as the codefenced language in 649 of the original skills. So, < 1% but…
| func TestAnalyze_MixedMismatches(t *testing.T) { | ||
| // java + config + shell + markup: 3 auxiliary mismatches | ||
| // java + config + shell + markup: all auxiliary, no app↔app mismatch | ||
| languages := []string{"java", "java", "yaml", "bash", "html"} |
|
|
||
| func TestAnalyze_AppAndAuxMixed(t *testing.T) { | ||
| // python + javascript + bash + yaml: only javascript is an app mismatch | ||
| languages := []string{"python", "python", "javascript", "bash", "yaml"} |
| func TestAnalyze_AuxPrimaryWithAppMismatch(t *testing.T) { | ||
| // bash appears most often (overall primary is shell/auxiliary), | ||
| // but javascript and python are both present → app↔app mismatch | ||
| languages := []string{"bash", "bash", "bash", "javascript", "python"} |
|
|
||
| func TestAnalyze_PurelyAuxiliary(t *testing.T) { | ||
| // Only auxiliary languages — no application languages at all | ||
| languages := []string{"bash", "yaml", "json", "sh"} |
Member
There was a problem hiding this comment.
sh is here but not shell and neither is present above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
As reported in #60 , we're currently warning on contamination even for cases where there are only auxiliary languages. This is unnecessarily noisy; the contamination check is intended to flag application programming languages for PLC risk. There is no research to support similar concerns exist for config languages or shell.
With these changes, the contamination check should now only fire when multiple application languages are detected.
How to test
New tests in:
And a new test fixture that contains only auxiliary languages to confirm correct behavior.
Checklist
go test -race ./... -count=1)golangci-lint run)